Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually attach Javadocs jar files to build #2988

Merged
merged 2 commits into from
Aug 23, 2022
Merged

Actually attach Javadocs jar files to build #2988

merged 2 commits into from
Aug 23, 2022

Conversation

tjleing
Copy link
Contributor

@tjleing tjleing commented Aug 19, 2022

Followup to #2971. maven-release-publisher.yml change was suspicious because Gradle should be able to determine that it's a dependency. This indicated that perhaps androidJavadocsJar was not a dependency after all.

Testing strategy: similar to #2971 but with dry build being done off of this branch instead of after merging to main, thanks @sdhuka!

image

Followups -- looks like Amplify isn't releasing Javadocs either despite adding Dokka. Also adding Javadocs HTML to docs website, and fixing errors/warnings as mentioned in #2971.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@tjleing tjleing marked this pull request as ready for review August 19, 2022 22:35
@tjleing tjleing requested a review from a team as a code owner August 19, 2022 22:35
@tjleing tjleing merged commit 363bb66 into main Aug 23, 2022
@tjleing tjleing deleted the leint/javadocs-2 branch August 23, 2022 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants