Allow users to specify the type of connection to use for s3 transfers. #575
Conversation
|
Hi @nasdf , Thanks for the PR we will start reviewing and update the thread afterward. |
minbi
added
s3
...-sdk-s3/src/main/java/com/amazonaws/mobileconnectors/s3/transferutility/TransferUtility.java
Outdated
Show resolved
Hide resolved
...-sdk-s3/src/main/java/com/amazonaws/mobileconnectors/s3/transferutility/TransferUtility.java
Outdated
Show resolved
Hide resolved
|
@kvasukib @cbommas Any updates on this PR? I'm very interested in using this feature in my project. Thanks! |
|
@danieldekerlegand We are still looking into the changes. I will post an update when the PR is merged and released. |
|
Any updates on this? |
|
Hi @cbommas, can you please take a look at this PR? |
|
@nasdf I have approved the changes. I will be pulling in the changes and write tests and will be including this in one of the future releases. Thank you! |
|
@kvasukib Is this feature available now? |
|
@cbommas Is this feature available now? |
|
@nasdf Sorry to bug you on this. Can you resolve the conflicts and update the PR? I am writing some tests for this change. |
| @@ -149,11 +149,8 @@ public void onReceive(Context context, Intent intent) { | |||
| new Thread(new Runnable() { | |||
| @Override | |||
| public void run() { | |||
| if (networkConnected) { | |||
There was a problem hiding this comment.
This needs to be worked on. The main feature of this class is to check for network connectivity and pause when offline and resume when online.
There was a problem hiding this comment.
I moved the network checking logic into the pauseAllForNetwork and checkTransfersOnNetworkReconnect methods so that each transfer can check if its network type is active or not. Does that not work with the updated SDK code?
There was a problem hiding this comment.
@nasdf Thank you for the information. However my concern is that, when a developer passes the TransferUtilityOptions via TransferUtility object, it is used for the transfers (upload and download). However the NetworkInfoReceiver / TransferService is not aware of that connection type chosen by the developer and we are checking for ANY.
My suggestion would be to find a way to be consistent with the connection type and use that everywhere in the SDK (TransferUtility, Upload/DownloadTask, TransferService and TransferNetworkLossHandler).
I am working on this suggestion and discussing with other folks in the team. I would like to know your approach for this use-case as well.
|
There are significant changes done in
|
|
Hey Guys, I'm waiting for long enough time to get this feature where we can mark Network type - WiFi or mobile data on uploading. If possible for you guys then please let me know when this feature would be available. Thanks for your time. |
|
@bharatUxarmy Sorry for the delay. I am working on integrating the changes with the current state of TransferUtility and adding tests. This should be included in the next upcoming release. |
|
Thank you @nasdf for the PR. This change has been released in 2.11.1 version of the SDK. I'm closing the PR as there are significant changes in the codebase which creates conflicts with the PR branch. Your work is highly appreciated! |
This change allows users to specify what type of connection they'd like to use for S3 transfers. For example you may only want to use WiFi to upload larger files.