Update CognitoSecretHash.java #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While creating CognitoUserPool instance using the awsConfiguration.json file with following description.
"CognitoUserPool": {
"Default": {
"PoolId": "xxxxxxxxxx",
"AppClientId": "xxxxxxxx",
"AppClientSecret": "",
"Region": "xxxx"
}
}
It will return appClientSecret as "" which is not checked in this file and cause crash in android application.
palpatim
requested changes
Nov 29, 2018
...main/java/com/amazonaws/mobileconnectors/cognitoidentityprovider/util/CognitoSecretHash.java
Outdated
Show resolved
Hide resolved
Closed the last quote in comment
minbi
approved these changes
Dec 3, 2018
|
Fixes #587 |
|
Just throwing in my two cents, but would it make sense to use the already existing There is already a method |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While creating CognitoUserPool instance using the awsConfiguration.json file with following description.
"CognitoUserPool": {
"Default": {
"PoolId": "xxxxxxxxxx",
"AppClientId": "xxxxxxxx",
"AppClientSecret": "",
"Region": "xxxx"
}
}
It will return appClientSecret as "" which is not checked in this file and cause crash in android application.