Fix cognito userpools username null in custom auth flow fixes #583 #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sagardvora Can you check if this fixes the issue for you? |
mutablealligator
approved these changes
Jan 24, 2019
It's still doesn't work @minbi. The issue still remains, which i have mentioned in #583 |
|
@sagardvora We are following up with you and your team in a separate thread. This PR still addresses a bug. We will be merging this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The custom flow starts, but fails to set the username in the initial request. This pull request does not change the internal username variable to limit the impact of this change.