[Userpools] Fix network calls to run in background when specified fixes #668 #702
Conversation
minbi
force-pushed
the
userpool-threading
branch
from
5e6f1c2 to
a1c1c2c
Compare
| return new Runnable() { | ||
| @Override | ||
| public void run() { | ||
| new Thread(new Runnable() { |
There was a problem hiding this comment.
It's very hard to understand what is going on here. Do you have any test cases that cover these changes?
E.g. the changes in this commit makes getSessionInBackground call AuthenticationHandler#onFailure() on background thread once user enters (incorrect) username/password and continueTask() has been called. onSuccess() is still called from main thread however. I would have expected the callbacks to run on main thread, or at least be consistent.
There was a problem hiding this comment.
There is a code fix that will be addressing the issue you have pointed out, the release is pending.
There was a problem hiding this comment.
Generally, this client calls the onSuccess and onFailure cases on the same thread that foo() is called. Except when the fooInBackground() variant is used, that is when the callbacks are made on the main thread's looper.
Also includes minor refactor of request method call structure.