Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enforce consistent imports, types, etc. #557

Merged
merged 11 commits into from
Feb 26, 2024

Conversation

josefaidt
Copy link
Contributor

Issue #, if available:

Description of changes:

adds a few eslint plugins to enforce consistent imports, types, etc.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@josefaidt josefaidt requested a review from a team as a code owner February 22, 2024 21:07
@josefaidt josefaidt changed the title bump svelte to latest patch enforce consistent imports, types, etc. Feb 22, 2024
@josefaidt josefaidt added the run-ci Label to trigger action run for CI label Feb 22, 2024
@github-actions github-actions bot removed the run-ci Label to trigger action run for CI label Feb 22, 2024
AnilMaktala
AnilMaktala previously approved these changes Feb 22, 2024
Copy link
Member

@AnilMaktala AnilMaktala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nadetastic
nadetastic previously approved these changes Feb 22, 2024
@nadetastic nadetastic dismissed stale reviews from AnilMaktala and themself via d98765a February 22, 2024 22:10
@nadetastic nadetastic added the run-ci Label to trigger action run for CI label Feb 22, 2024
@github-actions github-actions bot removed the run-ci Label to trigger action run for CI label Feb 22, 2024
@nadetastic nadetastic added the run-ci Label to trigger action run for CI label Feb 23, 2024
@github-actions github-actions bot removed the run-ci Label to trigger action run for CI label Feb 23, 2024
@nadetastic nadetastic added the run-ci Label to trigger action run for CI label Feb 23, 2024
@github-actions github-actions bot removed the run-ci Label to trigger action run for CI label Feb 23, 2024
nadetastic
nadetastic previously approved these changes Feb 23, 2024
@nadetastic nadetastic added the run-ci Label to trigger action run for CI label Feb 26, 2024
@github-actions github-actions bot removed the run-ci Label to trigger action run for CI label Feb 26, 2024
@nadetastic nadetastic added the run-ci Label to trigger action run for CI label Feb 26, 2024
@github-actions github-actions bot removed the run-ci Label to trigger action run for CI label Feb 26, 2024
@AnilMaktala AnilMaktala merged commit fd451a2 into aws-amplify:main Feb 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants