Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integrate i18n router #3750

Closed
wants to merge 8 commits into from
Closed

Conversation

watilde
Copy link
Contributor

@watilde watilde commented Nov 9, 2021

Related issue

#2648

Description of changes

This PR is to integrate i18n router as a foundation of further i18n integration and should have no breaking change. There seem to have two different type of documentation in terms of translation system - 1) html files with content json 2) mdx files; The scope of this PR is for the first one and I will make PR for automated mdx converting once we align on this router.

i18n router has two features - 1) Use en as a default locale and change nothing with the current website 2) Use local as a prefix for path and router automatically handle routing. Nothing happens if there is no translated resources.

Screenshots

Use en as a default local

https://localhost:3000/
Screen Shot 2021-11-09 at 11 19 25

Use ja as a prefix for path

https://localhost:3000/ja/
Screen Shot 2021-11-09 at 11 18 17

Use en content when translation does not exist

https://localhost:3000/ja/cli/

Screen Shot 2021-11-09 at 11 26 39

@watilde watilde requested a review from a team November 9, 2021 02:27
@watilde
Copy link
Contributor Author

watilde commented Nov 9, 2021

CI issue is related to vercel/next.js#18318. I'm investigating to fix now.

@watilde
Copy link
Contributor Author

watilde commented Nov 12, 2021

Turned out next export does not support i18n due to this reason: i18next/next-i18next#1466 (comment). This seems to be reasonable and we might can start discussion what to do first.

@watilde
Copy link
Contributor Author

watilde commented Jan 25, 2022

Rebased

@mauerbac
Copy link
Member

Will close in favor of team implementing i18n support

@mauerbac mauerbac closed this Mar 22, 2022
@watilde watilde deleted the initial-i18n branch June 10, 2022 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants