Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add PubSub Hub Connection state monitoring instructions #4540

Merged
merged 3 commits into from
Aug 22, 2022

Conversation

stocaaro
Copy link
Member

@stocaaro stocaaro commented Aug 22, 2022

Issue #, if available:

Description of changes:
Having added Hub messages corresponding the PubSub IoT and MQTT websocket connection changes in amplify-js PR #10136, this updates the PubSub documentation with basic instructions on how to access these messages.

image

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@stocaaro stocaaro requested a review from a team as a code owner August 22, 2022 19:48
@stocaaro stocaaro requested a review from a team August 22, 2022 19:48
@offlineprogrammer offlineprogrammer added the amplify/js Issues tied to JS label Aug 22, 2022
## Subscription connection status updates

Now that your application is setup and using pubsub subscriptions, you may want to know when the subscription is finally up and running, or reflect to your users when the subscription isn't healthy. You can monitor the connection state for changes via Hub.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to be more concrete like: you may want to know when the subscription is finally established, or reflect to ...

What do you think @stocaaro ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

Copy link
Contributor

@elorzafe elorzafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Thanks @stocaaro 🎉 🌮

@stocaaro stocaaro merged commit 1440c26 into aws-amplify:main Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
amplify/js Issues tied to JS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants