Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update services based on v1.42.52 of AWS Go SDK #118

Merged
merged 1 commit into from
Feb 13, 2022

Conversation

github-actions[bot]
Copy link
Contributor

This is an automated pull request.
It was triggered GitHub actions. The details can be found at
https://github.com/aws-beam/aws-elixir/actions/workflows/codegen.yml

For changes, please check https://github.com/aws/aws-sdk-go/releases/tag/v1.42.52

Copy link
Member

@onno-vos-dev onno-vos-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the aws-elixir PR got merged yesterday while the aws-erlang one did not. This explains why there is a diff in the nightly aws-erlang code while there isn't one here as the aws-erlang diff is essentially yesterday's diff in the PR that got created today 👍

Strangely enough there's no diff in generated code which I guess is fine as it'd simply mean they have made changes to their internal handling of the APIs.

@philss
Copy link
Contributor

philss commented Feb 13, 2022

@onno-vos-dev I was not watching the aws-erlang, so I didn't see the PR 😬

And yeah, I think it was a minor change. It was one of the error response in one of their APIs: aws/aws-sdk-go@v1.42.51...v1.42.52

@philss philss merged commit 00f02c2 into master Feb 13, 2022
@philss philss deleted the update-services-aws-sdk-go-v1.42.52 branch February 13, 2022 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants