S3 presigned choose between path and virtual host style #138
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently aws-erlang does path-style addressing for S3 presigned URLs - except for region
<<"local">>
- where virtual-host style addressing is being used.AWS on the other side is pushing towards virtual-host style addressing. So newer features are not available via path-style addressing.
My personal use case are S3 Object Lambda's, which - when addressed via path-style - just return a http redirect.
So this PR introduces the possibility to choose from the two options. To not introduce breaking changes, it defaults to path-style addressing while preserving the "hacks" for region
<<"local">>
.To make review easier, there are two commits