Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rule to validate AWS::Events::Rule ScheduleExpression #816

Open
fatbasstard opened this issue Apr 8, 2019 · 2 comments
Open

Add rule to validate AWS::Events::Rule ScheduleExpression #816

fatbasstard opened this issue Apr 8, 2019 · 2 comments
Labels
good first issue Good for newcomers new rule New rule p1 Medium Priority

Comments

@fatbasstard
Copy link
Contributor

Just spent way too much time on deploying a scheduled Lambda... The ScheduledExpression can be a Cron, but it's not really a normal Cron 🤔 (When using an online Cron tool at least).

The creating of the Sceduled event in the Lambda console is also not helping, since it validates the Cron at "Save" (try it, it's a lot of clicking to get an error.. Which you cannot easily edit 😛 )

Can we add this check to a new rule (or an existing one if we have one that fits)?

Sample Expression that breaks:

cron(0 */1 * * MON)

Sample Expression that's correct:

cron(1 * ? * MON *)

Documentation: https://docs.aws.amazon.com/lambda/latest/dg/tutorial-scheduled-events-schedule-expressions.html

@kddejong
Copy link
Contributor

kddejong commented Mar 7, 2020

There is a lot here to validate. Starting with the validation that Day-of-month or Day-of-week have a question mark. Not sure how much farther down this path I want to go now or continue to take it based on request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers new rule New rule p1 Medium Priority
Projects
None yet
Development

No branches or pull requests

3 participants