Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MVP rule for AWS::Events::Rule ScheduleExpression #1028

Merged
merged 4 commits into from
Jul 29, 2019

Conversation

fatbasstard
Copy link
Contributor

@fatbasstard fatbasstard commented Jul 16, 2019

Issue #816, if available:

This PR adds the initial (mvp) version of the rule to validate the ScheduleExpression of an AWS::Events::Rule.

These expressions can become pretty complex, and to prevent a bing-bang release of a complex rule that might break because of "reasons" (incorrect documentation, missed use-cases etc) this is a first version that adds:

  • The Rule to validate the ScheduleExpression
  • Test templates ("good" templates based on the given examples)

The rule now checks:

  • Only specific values (no intrinsic functions)
  • Checks for cron() or rate()
  • Validates the basic format of these 2 configuration

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@fatbasstard fatbasstard force-pushed the ScheduledExpression branch 2 times, most recently from 5fdf69c to 02d5bba Compare July 16, 2019 12:01
@fatbasstard fatbasstard reopened this Jul 16, 2019
@codecov
Copy link

codecov bot commented Jul 16, 2019

Codecov Report

Merging #1028 into master will increase coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1028      +/-   ##
==========================================
+ Coverage   86.89%   86.97%   +0.07%     
==========================================
  Files         133      134       +1     
  Lines        7892     7938      +46     
  Branches     1947     1954       +7     
==========================================
+ Hits         6858     6904      +46     
  Misses        640      640              
  Partials      394      394
Impacted Files Coverage Δ
...t/rules/resources/events/RuleScheduleExpression.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fb676c...0272c95. Read the comment docs.

@fatbasstard fatbasstard force-pushed the ScheduledExpression branch from 02d5bba to 736d93a Compare July 16, 2019 12:35
@fatbasstard fatbasstard reopened this Jul 16, 2019
@fatbasstard
Copy link
Contributor Author

Can be merged

@kddejong kddejong merged commit aec9c46 into aws-cloudformation:master Jul 29, 2019
@PatMyron PatMyron mentioned this pull request Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants