Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eu-south-1 (Milan) #1496

Merged
merged 4 commits into from
Apr 28, 2020
Merged

eu-south-1 (Milan) #1496

merged 4 commits into from
Apr 28, 2020

Conversation

PatMyron
Copy link
Contributor

@PatMyron PatMyron commented Apr 28, 2020

af-south-1 PR


https://aws.amazon.com/blogs/aws/now-open-aws-europe-milan-region/
https://aws.amazon.com/about-aws/whats-new/2020/04/announcing-the-new-aws-europe-milan-region/


resource specification documentation


$ aws ec2 describe-availability-zones --region eu-south-1 | grep 'ZoneName'
            "ZoneName": "eu-south-1a",
            "ZoneName": "eu-south-1b",
            "ZoneName": "eu-south-1c",

  • updated region_map from scripts/update_specs_from_pricing.py error:
$ scripts/update_specs_from_pricing.py
2020-04-28 07:42:46,752 - cfnlint - INFO - Get EC2 pricing
Traceback (most recent call last):
  File "scripts/update_specs_from_pricing.py", line 336, in <module>
    main()
  File "scripts/update_specs_from_pricing.py", line 319, in main
    outputs = update_outputs('Ec2InstanceType', get_ec2_pricing(), outputs)
  File "scripts/update_specs_from_pricing.py", line 102, in get_ec2_pricing
    if not results.get(region_map[product.get('attributes').get('location')]):
KeyError: u'EU (Milan)'

export REGION=eu-south-1
mkdir src/cfnlint/data/ExtendedSpecs/$REGION/
touch src/cfnlint/data/ExtendedSpecs/$REGION/05_pricing_property_values.json
touch src/cfnlint/data/ExtendedSpecs/$REGION/__init__.py
echo {} > src/cfnlint/data/CloudSpecs/$REGION.json

error unrelated to eu-south-1 (Milan):

$ scripts/update_specs_from_pricing.py
2020-04-28 08:11:45,873 - cfnlint - INFO - Get EC2 pricing
2020-04-28 08:45:39,410 - cfnlint - INFO - Get AmazonMQ pricing
2020-04-28 08:45:40,092 - cfnlint - INFO - Get RDS pricing
Traceback (most recent call last):
  File "scripts/update_specs_from_pricing.py", line 337, in <module>
    main()
  File "scripts/update_specs_from_pricing.py", line 322, in main
    outputs = update_outputs('RdsInstanceType', get_rds_pricing(), outputs)
  File "scripts/update_specs_from_pricing.py", line 235, in get_rds_pricing
    if not results.get(region_map[product.get('attributes').get('location')]):
KeyError: u'US West (Los Angeles)'

Regular auto-generated changes script:

pip3 install -e .
scripts/update_specs_from_pricing.py # requires Boto3 and Credentials
scripts/update_specs_services_from_ssm.py # requires Boto3 and Credentials
cfn-lint --update-specs
cfn-lint --update-iam-policies
cfn-lint --update-documentation

@codecov

This comment has been minimized.

@PatMyron PatMyron mentioned this pull request Apr 28, 2020
@PatMyron PatMyron marked this pull request as ready for review April 28, 2020 15:05
@kddejong kddejong merged commit 0b06b60 into master Apr 28, 2020
@kddejong kddejong deleted the PatMyron-patch-1 branch April 28, 2020 19:12
@PatMyron PatMyron mentioned this pull request Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants