exempting resource types where the AWS::Serverless transform sets DeletionPolicy but not UpdateReplacePolicy from W3011 #1529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
…etionPolicy but not UpdateReplacePolicy from W3011 #1265 https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-attribute-deletionpolicy.html https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-attribute-updatereplacepolicy.html
PatMyron
commented
May 13, 2020
Comment on lines
-254
to
+151
| 'exit_code': 6, | ||
| 'exit_code': 2, |
There was a problem hiding this comment.
transforms into template that previously violated W3011:
"myFunctionVersionee13cf2679": {
"DeletionPolicy": "Retain",
"Properties": {
"FunctionName": {
"Ref": "myFunction"
}
},
"Type": "AWS::Lambda::Version"
}
miparnisari
approved these changes
May 13, 2020
This was referenced May 13, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1265 because the
AWS::Serverlesstransform won't supportUpdateReplacePolicysoon while it's settingDeletionPolicyhere:AWS::Lambda::Version(docs)AWS::Lambda::LayerVersion(docs)Will investigate resources the
AWS::Serverlesstransform creates that could failI3011after