updates to RDS performance insight retention #2696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kddejong
approved these changes
Apr 17, 2023
|
I had that in my clipboard to add to the PR. apparently I never hit paste. |
kddejong
reviewed
Apr 17, 2023
test/fixtures/templates/bad/resources/rds/retention_period.yaml
Outdated
Show resolved
Hide resolved
|
I forgot to run cfn-lint --update-specs before doing the release. Should have this in the next release. Our automated maintenance task https://github.com/aws-cloudformation/cfn-lint/actions/workflows/maintenance.yaml will pick it up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates to RDS performance insight retention
Issue #, if available:
Description of changes:
AWS supports additional values for PerformanceInsightsRetentionPeriod. Instead of 7 and 731, it supports those plus month*31 where month is a number 1-23.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.