Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Allowed Values test and add values #542

Merged
merged 4 commits into from
Jan 2, 2019

Conversation

fatbasstard
Copy link
Contributor

@fatbasstard fatbasstard commented Jan 2, 2019

Issue #50, if available:

Tweaks and improvements on the Allowed Values:

  • Added GlueConnection Connection Input type
  • Create separate, specific fixtures for the allowed Values. Every Allowed Value now a correct and incorrect test data
  • Made a hotfix in the RecordSet rule along the way. It broke if no RecourceRecords are specified (allowed if an Alias is specifie), discovered this while building the (minimal) test fixtures

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-io
Copy link

codecov-io commented Jan 2, 2019

Codecov Report

Merging #542 into master will decrease coverage by 0.19%.
The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #542     +/-   ##
=========================================
- Coverage   84.54%   84.34%   -0.2%     
=========================================
  Files         110      110             
  Lines        5925     5928      +3     
  Branches     1342     1343      +1     
=========================================
- Hits         5009     5000      -9     
- Misses        604      614     +10     
- Partials      312      314      +2
Impacted Files Coverage Δ
src/cfnlint/rules/resources/route53/RecordSet.py 88.59% <25%> (-2.4%) ⬇️
...cfnlint/rules/resources/properties/AllowedValue.py 83.58% <0%> (-13.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cb9393...86f8606. Read the comment docs.

Copy link
Contributor

@kddejong kddejong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kddejong kddejong merged commit 2bdd9f7 into aws-cloudformation:master Jan 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants