-
Notifications
You must be signed in to change notification settings - Fork 588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AmazonMQ and APIGateway allowed values #552
Add AmazonMQ and APIGateway allowed values #552
Conversation
Codecov Report
@@ Coverage Diff @@
## master #552 +/- ##
=======================================
Coverage 84.23% 84.23%
=======================================
Files 109 109
Lines 5937 5937
Branches 1349 1349
=======================================
Hits 5001 5001
Misses 619 619
Partials 317 317
Continue to review full report at Codecov.
|
Fixed in the actual Spec files now
b76e9c7
to
b7fd534
Compare
Didn't read the documentation (https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/dynamic-references.html). It's actually not Supported
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Issue #50, if available:
Add allowed values for the Amazon MQ resources (
AWS::AmazonMQ::Broker
,AWS::AmazonMQ::Configuration
) and API Gateway (AWS::ApiGateway::Authorizer
,AWS::ApiGateway::GatewayResponse
,AWS::ApiGateway::RestApi
,AWS::ApiGateway::UsagePlanKey
)Along the way:
2.18
to2.18.1
, January 3 2019). See also: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/ReleaseHistory.htmlBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.