Add AmazonMQ and APIGateway allowed values #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #552 +/- ##
=======================================
Coverage 84.23% 84.23%
=======================================
Files 109 109
Lines 5937 5937
Branches 1349 1349
=======================================
Hits 5001 5001
Misses 619 619
Partials 317 317
Continue to review full report at Codecov.
|
Fixed in the actual Spec files now
fatbasstard
force-pushed
the
allowed_values
branch
from
b76e9c7
to
b7fd534
Compare
fatbasstard
changed the title
Didn't read the documentation (https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/dynamic-references.html). It's actually not Supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #50, if available:
Add allowed values for the Amazon MQ resources (
AWS::AmazonMQ::Broker,AWS::AmazonMQ::Configuration) and API Gateway (AWS::ApiGateway::Authorizer,AWS::ApiGateway::GatewayResponse,AWS::ApiGateway::RestApi,AWS::ApiGateway::UsagePlanKey)Along the way:
2.18to2.18.1, January 3 2019). See also: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/ReleaseHistory.htmlBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.