Add CodePipeline Allowed Values #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tweaked the existing CodePipeline rules: - Correct paths (all the error were thrown at Line `1:1` - Remove the Owners check since that's covered by the Allowed_values rule
Based on the [documentation](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-codepipeline-pipeline.html#cfn-codepipeline-pipeline-artifactstores), added `ArtifactStore`/`ArtificatStores` of CodePipeline to the `OnlyOne` check.
Codecov Report
@@ Coverage Diff @@
## master #599 +/- ##
=========================================
Coverage ? 84.42%
=========================================
Files ? 111
Lines ? 6061
Branches ? 1377
=========================================
Hits ? 5117
Misses ? 622
Partials ? 322
Continue to review full report at Codecov.
|
kddejong
approved these changes
Jan 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #50, if available:
Added the allowed values of all the
AWS::CodePipelineresources.Along the way:
Based on the documentation, added
ArtifactStore/ArtificatStoresof CodePipeline to theOnlyOnecheck.Tweaked the existing CodePipeline rules:
1:1By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.