Add CodeCommit allowed values #600
Conversation
fatbasstard
force-pushed
the
allowed_values
branch
from
7d97fcf
to
d82885a
Compare
Codecov Report
@@ Coverage Diff @@
## master #600 +/- ##
=========================================
Coverage ? 84.89%
=========================================
Files ? 113
Lines ? 6453
Branches ? 1505
=========================================
Hits ? 5478
Misses ? 627
Partials ? 348Continue to review full report at Codecov.
|
fatbasstard
force-pushed
the
allowed_values
branch
from
d82885a
to
7b9afd9
Compare
|
Closing this (temporary). Updating a lot of spec files in different branch results in merge hell... And caused me to loose changes in PR #586... (Hate myself for that). Let's work on 1 PR related to Spec files at once... |
fatbasstard
force-pushed
the
allowed_values
branch
from
7b9afd9
to
4646f0f
Compare
|
PR re-opened. Back in business... |
| @@ -168,10 +168,18 @@ Resources: | |||
| NotificationType: "ACTUAL" # Valid AllowedValue | |||
| ComparisonOperator: "GREATER_THAN" # Valid AllowedValue | |||
| Certificate: | |||
| Type: AWS::CertificateManager::Certificate | |||
| Type: "AWS::CertificateManager::Certificate" | |||
There was a problem hiding this comment.
This seems like a weird change. Was there a particular reason for this?
There was a problem hiding this comment.
Constency, like the commit description says. Just cosmetics...
BTW: The AWS documentation itself is inconsistent with this as well. Some documentation uses quoted, some don't:
Without: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-certificatemanager-certificate.html
With: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-amazonmq-configuration.html
I liked to keep it consistent with the quotes in the entire stack ;)
Issue #50, if available:
Added the allowed values of all the
AWS::CodeCommitresources.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.