-
Notifications
You must be signed in to change notification settings - Fork 588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CodeCommit allowed values #600
Add CodeCommit allowed values #600
Conversation
7d97fcf
to
d82885a
Compare
Codecov Report
@@ Coverage Diff @@
## master #600 +/- ##
=========================================
Coverage ? 84.89%
=========================================
Files ? 113
Lines ? 6453
Branches ? 1505
=========================================
Hits ? 5478
Misses ? 627
Partials ? 348 Continue to review full report at Codecov.
|
d82885a
to
7b9afd9
Compare
Closing this (temporary). Updating a lot of spec files in different branch results in merge hell... And caused me to loose changes in PR #586... (Hate myself for that). Let's work on 1 PR related to Spec files at once... |
7b9afd9
to
4646f0f
Compare
PR re-opened. Back in business... |
@@ -168,10 +168,18 @@ Resources: | |||
NotificationType: "ACTUAL" # Valid AllowedValue | |||
ComparisonOperator: "GREATER_THAN" # Valid AllowedValue | |||
Certificate: | |||
Type: AWS::CertificateManager::Certificate | |||
Type: "AWS::CertificateManager::Certificate" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a weird change. Was there a particular reason for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Constency, like the commit description says. Just cosmetics...
BTW: The AWS documentation itself is inconsistent with this as well. Some documentation uses quoted, some don't:
Without: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-certificatemanager-certificate.html
With: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-amazonmq-configuration.html
I liked to keep it consistent with the quotes in the entire stack ;)
Issue #50, if available:
Added the allowed values of all the
AWS::CodeCommit
resources.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.