Add Rules to ordering #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue #, if available: No Issue Description of changes: We currently have Rules in our Cloudformation template. It looks like, since this isn't included in the ordering, it automatically get's pushed at the bottom of the file. It would be nice to see Rules being consistently placed in the same position in the template. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
|
Perhaps |
Thanks, this is a good point, I have updated to follow this. |
|
I have now updated the tests to include Rules too. |
|
I'm not strictly the maintainer for this project, so I'll defer review to someone more official 😄 I'd consider this a minor breaking change. Before this change After this change the rules section will be below the |
|
lgtm pending commit history tidy up :) |
added 2 commits
May 17, 2023 14:28
jameslevine
force-pushed
the
add-missing-rules-to-ordering
branch
from
8ab0f31
to
eaf9cfa
Compare
Should be tidied up now 👍 |
ericzbeard
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
No Issue
Description of changes:
We currently have Rules in our CloudFormation template. It looks like, since this isn't included in the ordering, it automatically gets pushed at the bottom of the file.
It would be nice to see Rules being consistently placed in the same position in the template.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.