Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added force option to deploy stacksets without intervention #143

Conversation

hariprakash-j
Copy link
Collaborator

Description of changes:

Added -f or --force to deploy stacksets without user intervention and generated the updated docs.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@hariprakash-j
Copy link
Collaborator Author

A bit more context as to why this is needed, I use this in a CICD pipeline and not having this option makes it unusable for stacksets.

@@ -43,6 +43,7 @@ rain stackset deploy <template> [stackset] [flags]
--accounts strings accounts for which to create stack set instances
-c, --config string YAML or JSON file to set additional configuration parameters
-d, --detach once deployment has started, don't wait around for it to finish
-f, --force update the stackset without confirmation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would -y be a better option to match the deploy command?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup that's more consistent. I fixed it.

Copy link
Contributor

@ericzbeard ericzbeard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but we have conflicts with the auto generated docs from another PR.

@hariprakash-j hariprakash-j force-pushed the fix/stackset-deploy-no-confirm branch from 1ec4f33 to de8c2f6 Compare June 3, 2023 06:45
@hariprakash-j
Copy link
Collaborator Author

fixed the conflicts 👍

@ericzbeard ericzbeard merged commit 6c9e91a into aws-cloudformation:main Jun 5, 2023
@hariprakash-j hariprakash-j deleted the fix/stackset-deploy-no-confirm branch June 19, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants