Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: update S3 url for handling china region #227

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

bartleboeuf
Copy link
Contributor

Issue #213 :

Description of changes:

  • Handle S3 url for S3 in AWS Mainland China in case of template upload.

Tests:

  • Tests are made in our CI/CD environment in Beijing region :
DEBUG: Preparing template 'main.yml'
DEBUG: Loading AWS config
DEBUG: Artifact bucket: cf-templates-m89vz00plzen-cn-north-1
DEBUG: transform path: Resources/*|Type==AWS::CloudFormation::Stack/Properties/TemplateURL
DEBUG: transform path: Resources/*|Type==AWS::CloudFormation::Stack/Properties/TemplateURL
DEBUG: transform path: Resources/*|Type==AWS::CloudFormation::Stack/Properties/TemplateURL
DEBUG: transform path: Resources/*|Type==AWS::CloudFormation::Stack/Properties/TemplateURL
DEBUG: transform path: Resources/*|Type==AWS::CloudFormation::Stack/Properties/TemplateURL
DEBUG: transform path: Resources/*|Type==AWS::CloudFormation::Stack/Properties/TemplateURL
DEBUG: transform path: Resources/*|Type==AWS::CloudFormation::Stack/Properties/TemplateURL
DEBUG: transform path: Resources/*|Type==AWS::CloudFormation::Stack/Properties/TemplateURL
DEBUG: transform path: Resources/*|Type==AWS::CloudFormation::Stack/Properties/TemplateURL
DEBUG: transform path: Resources/*|Type==AWS::CloudFormation::Stack/Properties/TemplateURL
DEBUG: Checking current status of stack 'stack-tools-non-production-main'
DEBUG: Stack exists
DEBUG: Handling parameters
DEBUG: Creating change set
DEBUG: Template is too large to deploy directly; uploading to S3.
DEBUG: Artifact bucket: cf-templates-m89vz00plzen-cn-north-1
DEBUG: Artifact key: stack-tools-non-production-main/73f8b3aef23a21519d0d4f88df0d83056de5b0d638492ec9fc3dcf4743176927
DEBUG: ChangeSet status: CREATE_PENDING
DEBUG: ChangeSet status: CREATE_IN_PROGRESS
DEBUG: ChangeSet status: CREATE_IN_PROGRESS
DEBUG: ChangeSet status: CREATE_IN_PROGRESS
DEBUG: ChangeSet status: CREATE_IN_PROGRESS
DEBUG: ChangeSet status: CREATE_COMPLETE
Deploying template 'main.yml' as stack 'stack-tools-non-production-main' in cn-north-1.
DEBUG: 
Stack stack-tools-non-production-main: UPDATE_COMPLETE
Successfully updated stack-tools-non-production-main

@ericzbeard ericzbeard merged commit b9be3d4 into aws-cloudformation:main Dec 12, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants