-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite the build command to use registry schemas instead of spec files #262
Conversation
@hariprakash-j, @khmoryz, @null93, @iainelder Please let me know what you think of this when you have time. I'm honestly not even sure how many people use the |
Hi @ericzbeard I think your improvement is great. I use I think major version upgrade is not a problem, because I don't think As for the |
I cannot speak too much on this because I don't use the If this PR makes the output more accurate, I think that is great! |
Just catching up now after an extended break from GitHub. I don't use the Can I use the feature to write correct templates more quickly? |
Yes, and I just added a new feature to the build command to emit fully functional, tested templates for certain use cases. It's not released yet so you would need to install from
|
Sounds awesome! For a VS Code user, what does the workflow look like? I'm thinking:
A way to use the template generation from inside VS Code would be awesome too. Maybe out of scope for this repo, but another repo with an extension for VS Code could handle it. |
This is a breaking change to the way the
build
command works. Instead of using a locally stored copy of the spec file, we now download the current schema from the registry in your account/region. In some ways this will be more accurate, since the registry schemas are more expressive and represent the source of truth going forward. But registry coverage is not yet 100%, so some resources will not build correctly. I added a patching mechanism so that we can improve the output when the schemas are lacking.SAM templates used to be generated based on parsing documentation files, which are no longer maintained, so we switched to parsing a simplified SAM schema from the
goformation
project and converting it into the registry schema format.