Exit with a success code instead of a panic when change set includes no change. #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stilvoid
requested changes
Apr 1, 2022
internal/aws/cfn/cfn.go
Outdated
| @@ -261,7 +265,11 @@ func CreateChangeSet(template cft.Template, params []types.Parameter, tags map[s | |||
| config.Debugf("ChangeSet status: %s", status) | |||
|
|
|||
| if status == "FAILED" { | |||
| return changeSetName, errors.New(ptr.ToString(res.StatusReason)) | |||
| if ptr.ToString(res.StatusReason) == noChangeFoundMsg { | |||
There was a problem hiding this comment.
I don't think this logic adds any value here. Would prefer moving this into the deploy command to decide behaviour there.
There was a problem hiding this comment.
Thank you for this feedback! I was just debating wheter I should add this logic into deploy.go or not. I'll modify it.
… or not into deploy.go.
stilvoid
reviewed
Apr 1, 2022
internal/cmd/deploy/deploy.go
Outdated
| @@ -159,7 +161,12 @@ YAML: | |||
| spinner.Push("Creating change set") | |||
| changeSetName, createErr := cfn.CreateChangeSet(template, parameters, combinedTags, stackName, roleArn) | |||
| if createErr != nil { | |||
| panic(ui.Errorf(createErr, "error creating changeset")) | |||
| if createErr.Error() == noChangeFoundMsg { | |||
| fmt.Println(console.Green("\nChange set was created, but there is no change. Deploy was skipped.")) | |||
There was a problem hiding this comment.
If you put a spinner.Pop() just before this, you won't need the \n at the beginning of the message :)
There was a problem hiding this comment.
What a awesome utility!
https://github.com/aws-cloudformation/rain/blob/main/internal/console/spinner/spinner.go
I'll use this.
ericzbeard
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #73
Description of changes: When change set includes no change, rain exits with a success code instead of a panic.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.