-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Origin Access Control CRD #41
Add support for Origin Access Control CRD #41
Conversation
ec837c8
to
d2a3de8
Compare
updates = { | ||
"spec": {"originAccessControlConfig": {"description": "new description"}}, | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're so lucky we don't have arrays in this CRDs, we don't have write another massacre like https://github.com/aws-controllers-k8s/cloudfront-controller/blob/main/pkg/resource/distribution/hooks.go#L29-L34
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super neat! thanks!
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, TiberiuGC The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@TiberiuGC @a-hilaly
my IAM role has these policies attached That role mapped to the service account . Am i missing anything |
@bala151187 this sounds like an RBAC issue, did you update the helm chart as well? |
@a-hilaly Yeah . i just manually updated the image version :) . image: public.ecr.aws/aws-controllers-k8s/cloudfront-controller:0.0.12 |
Updating the deployment image alone isn't enough, you need to use the latest helm chart (it contains the right RBAC for this version of the controller) |
@a-hilaly hmm .. then that's the missing piece .. gotcha .. ll let you know on monday .. thanks for replying |
Issue #, if available: aws-controllers-k8s/community#2093
Description of changes: add support for Origin Access Control CRD
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.