Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update controller tools to v0.9.2 #361

Merged

Conversation

RedbackThomson
Copy link
Contributor

Fixes aws-controllers-k8s/community#1438

Description of changes:
The current version of controller-tools does not support go1.19 (failing with internal atomic type failures). This pull request updates to the latest version, which works as expected.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
/lgtm

@ack-bot ack-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 6, 2022
@ack-bot
Copy link
Collaborator

ack-bot commented Sep 6, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: A-Hilaly, RedbackThomson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [A-Hilaly,RedbackThomson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-bot ack-bot merged commit ae64dcd into aws-controllers-k8s:main Sep 6, 2022
@RedbackThomson RedbackThomson deleted the controller-gen-0.9.2 branch September 7, 2022 18:23
@brycahta
Copy link
Contributor

brycahta commented Sep 7, 2022

Nice! ec2-controller Fleet should be unblocked now!

related: kubernetes-sigs/controller-tools#667

@RedbackThomson
Copy link
Contributor Author

Nice! ec2-controller Fleet should be unblocked now!

related: kubernetes-sigs/controller-tools#667

We can finally have our Floot changed to Fleets!

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Controllers Fail Generation When Golang 1.19 is Used Locally
4 participants