Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to ACK runtime v0.30.0, code-generator v0.30.0 #179

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

ack-bot
Copy link
Collaborator

@ack-bot ack-bot commented Feb 14, 2024

Update to ACK runtime v0.30.0, code-generator v0.30.0



NOTE:
This PR increments the release version of service controller from v1.2.2 to v1.2.3

Once this PR is merged, release v1.2.3 will be automatically created for ec2-controller

Please close this PR, if you do not want the new patch release for ec2-controller


stdout for make build-controller:

building ack-generate ... ok.
==== building ec2-controller ====
Copying common custom resource definitions into ec2
Building Kubernetes API objects for ec2
Generating deepcopy code for ec2
Generating custom resource definitions for ec2
Building service controller for ec2
Generating RBAC manifests for ec2
Running gofmt against generated code for ec2
Updating additional GitHub repository maintenance files
==== building ec2-controller release artifacts ====
Building release artifacts for ec2-v1.2.3
Generating common custom resource definitions
Generating custom resource definitions for ec2
Generating RBAC manifests for ec2

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-bot ack-bot added the prow/auto-gen PRs related to prow auto generation automation label Feb 14, 2024
@ack-prow ack-prow bot requested review from a-hilaly and jljaco February 14, 2024 03:57
@a-hilaly
Copy link
Member

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2024
Copy link

ack-prow bot commented Feb 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, ack-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot added the approved label Feb 14, 2024
@ack-prow ack-prow bot merged commit 7493140 into main Feb 14, 2024
6 checks passed
nnbu pushed a commit to nnbu/ack-ec2-controller that referenced this pull request Sep 18, 2024
…llers-k8s#179)

### Update to ACK runtime `v0.30.0`, code-generator `v0.30.0`

----------

* ACK code-generator `v0.30.0` [release notes](https://github.com/aws-controllers-k8s/code-generator/releases/tag/v0.30.0)
* ACK runtime `v0.30.0` [release notes](https://github.com/aws-controllers-k8s/runtime/releases/tag/v0.30.0)

----------

NOTE:
This PR increments the release version of service controller from `v1.2.2` to `v1.2.3`

Once this PR is merged, release `v1.2.3` will be automatically created for `ec2-controller`

**Please close this PR, if you do not want the new patch release for `ec2-controller`**

----------

#### stdout for `make build-controller`:

```
building ack-generate ... ok.
==== building ec2-controller ====
Copying common custom resource definitions into ec2
Building Kubernetes API objects for ec2
Generating deepcopy code for ec2
Generating custom resource definitions for ec2
Building service controller for ec2
Generating RBAC manifests for ec2
Running gofmt against generated code for ec2
Updating additional GitHub repository maintenance files
==== building ec2-controller release artifacts ====
Building release artifacts for ec2-v1.2.3
Generating common custom resource definitions
Generating custom resource definitions for ec2
Generating RBAC manifests for ec2
```

----------

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Indicates that a PR is ready to be merged. prow/auto-gen PRs related to prow auto generation automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants