Add annotations to configure final snapshot and automated backup deletion #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/retest |
a-hilaly
force-pushed
the
deletion-annotations
branch
from
34077ec
to
966a043
Compare
a-hilaly
changed the title
deletion This commit adds support for configuring delete options for DBInstances and DBclusters via resource annotations: - `SkipFinalSnapshot` (default: true): Skip taking a final snapshot before deletion - `FinalDBSnapshotIdentifier`: Specify the identifier of the final snapshot - `DeleteAutomatedBackups` (default: true): Delete automated backups associated with the instance/cluster The generator config is updated to use `sdk_delete_post_build_request` hook which parses the annotations and set the appropriate fields on `DeleteDBInstanceInput` and `DeleteDBClusterInput`. The default behaviour remains unchanged (skip final snapshot, retain automated backups), but users can now opt-in to taking a final snapshot or deleting automatedd backups by setting the corresponding annotations on the resource.
a-hilaly
force-pushed
the
deletion-annotations
branch
from
966a043
to
18e1635
Compare
a-hilaly
added
the
do-not-merge/hold
|
/lgtm |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, ack-bot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
a-hilaly
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for configuring delete options for DBInstances
and DBclusters via resource annotations:
SkipFinalSnapshot(default: true): Skip taking a final snapshotbefore deletion
FinalDBSnapshotIdentifier: Specify the identifier of the finalsnapshot
DeleteAutomatedBackups(default: true): Delete automated backupsassociated with the instance/cluster
The generator config is updated to use
sdk_delete_post_build_requesthook which parses the annotations and set the appropriate fields on
DeleteDBInstanceInputandDeleteDBClusterInput.The default behaviour remains unchanged (skip final snapshot, retain
automated backups), but users can now opt-in to taking a final snapshot
or deleting automatedd backups by setting the corresponding annotations
on the resource.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.