Use resource descriptor GVK for NewSession
#120
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Some version of K8s do not reliably return
TypeMeta
information when you callapiReader.Get()
(see kubernetes/kubernetes#3030 and kubernetes/kubernetes#80609). This is a known bug incontroller-runtime
that they don't plan on fixing.Parts of the code, namely around setting up the user agent, currently rely on these fields - and they are currently being given an empty struct (with empty strings for all values). To work around this bug, this PR has introduced a new
GroupVersionKind()
getter in theResourceDescriptor
(replacing the existingGroupKind
), which returns a static description of the GVK. Then, rather than referencing theRuntimeObject
TypeMeta
properties, we can reference this new GVK getter anywhere in the runtime. It also replaces any existing use ofGroupKind
to now useGroupVersionKind
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.