Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed requirements for integration testing #310

Merged
merged 1 commit into from
Mar 2, 2023

Conversation

jljaco
Copy link
Contributor

@jljaco jljaco commented Feb 16, 2023

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 16, 2023
@ack-prow ack-prow bot requested review from a-hilaly and vijtrip2 February 16, 2023 15:57
@ack-prow ack-prow bot added the approved label Feb 16, 2023
@jljaco jljaco marked this pull request as ready for review February 16, 2023 16:53
@ack-prow ack-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 16, 2023
Copy link
Collaborator

@jaypipes jaypipes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be cool to make each item an issue (if it isn't already) and then add a GH Project to track progress on these related items.

docs/design/proposal/e2e-testing-v2.md Show resolved Hide resolved
docs/design/proposal/e2e-testing-v2.md Show resolved Hide resolved
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+++

@jljaco
Copy link
Contributor Author

jljaco commented Mar 1, 2023

Would be cool to make each item an issue (if it isn't already) and then add a GH Project to track progress on these related items.

Project is https://github.com/orgs/aws-controllers-k8s/projects/8/

GH issues forthcoming!

@jljaco jljaco requested a review from jaypipes March 1, 2023 19:13
@RedbackThomson
Copy link
Contributor

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 2, 2023
@ack-prow
Copy link

ack-prow bot commented Mar 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: A-Hilaly, jljaco, RedbackThomson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [A-Hilaly,RedbackThomson,jljaco]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot merged commit 4ccd860 into aws-controllers-k8s:main Mar 2, 2023
@jljaco jljaco deleted the e2e_testing_v2_reqs branch March 2, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
No open projects
4 participants