fix: auto-install GUI dependencies #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephen Crowe <crowest@amazon.com>
Signed-off-by: Stephen Crowe <crowest@amazon.com>
|
lucaseck
approved these changes
Sep 5, 2024
amarsjac
approved these changes
Sep 5, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
The submitter fails if the locally installed Deadline Client does not have GUI dependencies installed.
What was the solution? (How)
Use the new
--install-guiflag to auto-install the dependencies.What is the impact of this change?
The submitter works with a fresh, GUI-less install of the Deadline Client.
How was this change tested?
I uninstall Pyside and verified they were gone by manually running
deadline bundle gui-submit --browseand seeing the "install dependencies" prompt. I then ran the Keyshot submitter and it opened as expected. After it opened, I confirmed that Pyside was installed silently.Was this change documented?
Not needed.
Is this a breaking change?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.