Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: package and publish Keyshot plugin to the GitHub release #118

Merged

Conversation

moorec-aws
Copy link
Contributor

What was the problem/requirement? (What/Why)

  1. Version files in keyshot script are not updated when a new version is released
  2. Users are required to git clone the release branch to use the latest submitter.

What was the solution? (How)

  1. Update the script and adaptor version in the Submit to AWS Deadline Cloud.py script.
  2. Zip the contenets of keyshot_submitter into the dist_extras directory during the release proces.

What is the impact of this change?

  1. Proper versions updated in plugin file when we do a release
  2. Users can access the plugin from the release page.

How was this change tested?

Tested in a development environment using the reusable_bump and reusable publish workflows.

  • Confirmed that the versions are updated properly in the ChangeLog PR.
  • Confirmed that the zip exist on the release page with the expected contents.

Was this change documented?

No

Is this a breaking change?

No


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Signed-off-by: Charles Moore <moorec@amazon.com>
Copy link

sonarcloud bot commented Sep 19, 2024

@moorec-aws moorec-aws marked this pull request as ready for review September 19, 2024 18:43
@moorec-aws moorec-aws requested a review from a team as a code owner September 19, 2024 18:43
@moorec-aws moorec-aws merged commit c2760a0 into aws-deadline:mainline Sep 19, 2024
12 checks passed
@moorec-aws moorec-aws deleted the moorec/release_plugin_files branch September 19, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants