Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deps)!: update openjd-adaptor-runtime to 0.5 #108

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

epmog
Copy link
Contributor

@epmog epmog commented Mar 4, 2024

Run is no longer the default adaptor action

What was the problem/requirement? (What/Why)

Needed to update to the latest openjd adaptor runtime

What was the solution? (How)

Updated, and added a SemVer for the openjd interface

What is the impact of this change?

Our unversioned API is now versioned

How was this change tested?

hatch run fmt
hatch build
hatch run lint
hatch run test

Was this change documented?

N/A

Is this a breaking change?

Yes, nothing to do on the customer's side unless they wrote custom job templates that don't specify an action and expected run to happen.

@epmog epmog requested a review from a team as a code owner March 4, 2024 23:43
breaking change:
* the default action when using the adaptor is no longer run. If a custom job template was written without specifying an action, they must be now updated to choose run.

signed-off-by: Morgan Epp <60796713+epmog@users.noreply.github.com>
Copy link
Contributor

@ddneilson ddneilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the title be fix or feat so that it shows up in changelogs?

@epmog epmog changed the title chore!(deps): update openjd-adaptor-runtime to 0.5 feat(deps)!: update openjd-adaptor-runtime to 0.5 Mar 6, 2024
@epmog epmog merged commit cc119f6 into mainline Mar 6, 2024
6 checks passed
@epmog epmog deleted the update_adaptor_runtime branch March 6, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants