Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add bash shell to bump and release actions #175

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

moorec-aws
Copy link
Contributor

What was the problem/requirement? (What/Why)

A shell needs to be specified for the bump and release hook actions

What was the solution? (How)

Specify bash for the shell

What is the impact of this change?

allows actions to run shell commands

How was this change tested?

Yes, in a developer github account

Did you run the "Job Bundle Output Tests"? If not, why not? If so, paste the test results here.

Not required, this is a CI change.

Was this change documented?

No

Is this a breaking change?

No


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Signed-off-by: Charles Moore <moorec@amazon.com>
@moorec-aws moorec-aws requested a review from a team as a code owner September 19, 2024 19:37
Copy link

sonarcloud bot commented Sep 19, 2024

@moorec-aws moorec-aws merged commit 52bd828 into aws-deadline:mainline Sep 19, 2024
12 checks passed
@moorec-aws moorec-aws deleted the moorec/add-shell branch September 19, 2024 19:41
@@ -8,6 +8,7 @@ runs:
using: composite
steps:
- name: Update plugin Version
shell: bash
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, what's the behavior without the shell specification? Was the action failing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants