Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prevent duplicate submitter dialogs, and show submitter over Maya Window #26

Merged
merged 4 commits into from
Oct 10, 2023

Conversation

rmv
Copy link
Contributor

@rmv rmv commented Sep 20, 2023

What was the problem/requirement? (What/Why)

  • clicking multiple times on the Deadline Submitter Icon would create multiple submitters
  • Submitter window is created under the Maya window, unlike all the other Maya tools

What was the solution? (How)

  • only create a submitter window when none is present, otherwise show the existing one
  • pass along the Qt.tool flag to keep dialog on top of the main maya window

The submitter dialog stands somewhat in between a modal and non modal window, it's a modal command masquerading as a tool. All its stored data could become out of sync as the user edits and overwrites the underlying file or even loads a new file. Typically this is solved by adding a Refresh button to the tool.

I checked how this was handled in Deadline Classic to keep things as simple and useful/less confusing for users. In Deadline Classic this is implemented by keeping the data persistent and resetting the dialog when a new file is loaded.

File A is loaded:

  • Dialog can be hidden or shown when the submitter button is pressed, data is persistent

After a new file load:

  • Dialog can be refreshed by pressing the submitter button (settings reset, name set to new file)
  • If Dialog is kept open the old settings are preserved, including the referenced file.

What is the impact of this change?

No more duplicates of submitter dialog, dialog stays on top.

How was this change tested?

unit tests passed,
test 1- load file, press button multiple times: only one submitter present, data preserved
test 2- load file, press button multiple times, modify data, close, press button multiple times: 1 submitter, data preserved
test 3- load file, press button multiple times, modify data, load file 2, press button multiple times: 1 submitter, data reset

Did you run the "Job Bundle Output Tests"? If not, why not? If so, paste the test results here.

No, does not impact job bundles.

Was this change documented?

SIM

Is this a breaking change?

No

@rmv rmv requested a review from a team as a code owner September 20, 2023 15:31
@rmv rmv force-pushed the rmvh/maya_fix_multiple_submitters branch from 76acee5 to ebe8b0f Compare September 20, 2023 15:58
…a window

Signed-off-by: Ramon Montoya Vozmediano <1171039+rmv@users.noreply.github.com>
@rmv rmv force-pushed the rmvh/maya_fix_multiple_submitters branch from ebe8b0f to d5c6845 Compare September 20, 2023 17:48
@rmv rmv merged commit b0d36fe into mainline Oct 10, 2023
6 checks passed
@rmv rmv deleted the rmvh/maya_fix_multiple_submitters branch October 10, 2023 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants