fix: Prevent duplicate submitter dialogs, and show submitter over Maya Window #26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
What was the solution? (How)
The submitter dialog stands somewhat in between a modal and non modal window, it's a modal command masquerading as a tool. All its stored data could become out of sync as the user edits and overwrites the underlying file or even loads a new file. Typically this is solved by adding a Refresh button to the tool.
I checked how this was handled in Deadline Classic to keep things as simple and useful/less confusing for users. In Deadline Classic this is implemented by keeping the data persistent and resetting the dialog when a new file is loaded.
File A is loaded:
After a new file load:
What is the impact of this change?
No more duplicates of submitter dialog, dialog stays on top.
How was this change tested?
unit tests passed,
test 1- load file, press button multiple times: only one submitter present, data preserved
test 2- load file, press button multiple times, modify data, close, press button multiple times: 1 submitter, data preserved
test 3- load file, press button multiple times, modify data, load file 2, press button multiple times: 1 submitter, data reset
Did you run the "Job Bundle Output Tests"? If not, why not? If so, paste the test results here.
No, does not impact job bundles.
Was this change documented?
SIM
Is this a breaking change?
No