Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add clarification to testing instructions #47

Closed
wants to merge 1 commit into from

Conversation

amarsjac
Copy link
Contributor

@amarsjac amarsjac commented Nov 3, 2023

What was the problem/requirement? (What/Why)

instructions are unclear for some of the manual testing

What was the solution? (How)

added some clarification to better explain the required steps

What is the impact of this change?

better developer experience

How was this change tested?

looked at markdown preview of affected docs, confirmed new link works locally

Did you run the "Job Bundle Output Tests"? If not, why not? If so, paste the test results here.

no, I only changes readme style documentation

Required: paste the contents of job_bundle_output_tests/test-job-bundle-results.txt here

Was this change documented?

it is documentation

Is this a breaking change?

no

@amarsjac amarsjac requested a review from a team as a code owner November 3, 2023 16:40
Copy link

sonarcloud bot commented May 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@epmog
Copy link
Contributor

epmog commented Nov 1, 2024

These instructions have been overhauled since. Closing

@epmog epmog closed this Nov 1, 2024
@epmog epmog deleted the amarsjac/test_documentation_tweak branch November 1, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants