Skip to content

Commit

Permalink
chore: addressed PR feedback
Browse files Browse the repository at this point in the history
Signed-off-by: Cherie-Chen <58997764+Cherie-Chen@users.noreply.github.com>
  • Loading branch information
Cherie-Chen authored and Haejung Choi committed Sep 5, 2024
1 parent ac60bf5 commit 80bd8be
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 16 deletions.
18 changes: 5 additions & 13 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,18 +12,18 @@ AWS Deadline Cloud for Nuke is a python package that allows users to create [AWS
[openjd-adaptor-runtime]: https://github.com/OpenJobDescription/openjd-adaptor-runtime-for-python
[openjd-adaptor-runtime-lifecycle]: https://github.com/OpenJobDescription/openjd-adaptor-runtime-for-python/blob/release/README.md#adaptor-lifecycle

## Submitter

This package provides a Nuke plugin that creates jobs for AWS Deadline Cloud using the [AWS Deadline Cloud client library][deadline-cloud-client]. Based on the loaded comp it determines the files required, allows the user to specify render options, and builds an [OpenJD template][openjd] that defines the workflow.

### Compatibility
## Compatibility

This library requires:

1. Nuke 15,
1. Python 3.9 or higher; and
1. Linux, Windows, or a macOS operating system.

## Submitter

This package provides a Nuke plugin that creates jobs for AWS Deadline Cloud using the [AWS Deadline Cloud client library][deadline-cloud-client]. Based on the loaded comp it determines the files required, allows the user to specify render options, and builds an [OpenJD template][openjd] that defines the workflow.

## Adaptor

The Nuke Adaptor implements the [OpenJD][openjd-adaptor-runtime] interface that allows render workloads to launch Nuke and feed it commands. This gives the following benefits:
Expand All @@ -33,14 +33,6 @@ The Nuke Adaptor implements the [OpenJD][openjd-adaptor-runtime] interface that

Jobs created by the submitter use this adaptor by default.

### Compatibility

This library requires:

1. Nuke 15,
1. Python 3.9 or higher; and
1. Linux operating system.

### Getting Started

The adaptor can be installed by the standard python packaging mechanisms:
Expand Down
3 changes: 1 addition & 2 deletions install_builder/deadline-cloud-for-nuke.xml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
<onPackingFilterList>
<fileNameFilter pattern="*/deadline/nuke_submitter/*" logic="matches" patternType="glob"/>
<fileNameFilter pattern="*/deadline/nuke_util/*" logic="matches" patternType="glob"/>
<fileNameFilter pattern="*/deadline/nuke_submitter/menu.py" logic="matches" patternType="glob"/>
</onPackingFilterList>
</distributionDirectory>
</distributionFileList>
Expand Down Expand Up @@ -77,7 +76,7 @@
<fnAddPathEnvironmentVariable>
<progressText>Setting NUKE_PATH</progressText>
<name>NUKE_PATH</name>
<value>${nuke_installdir}</value>
<value>${nuke_installdir}\deadline\nuke_submitter</value>
<scope>${installscope}</scope>
<insertAt>end</insertAt>
</fnAddPathEnvironmentVariable>
Expand Down
2 changes: 1 addition & 1 deletion src/deadline/nuke_submitter/menu.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ def add_deadline_menu() -> None:
run_render_submitter_job_bundle_output_test,
"",
)
except BaseException:
except Exception:
print("Failed to load deadline.nuke_submitter. Reason:", file=sys.stderr)
print(traceback.format_exc(), file=sys.stderr)

Expand Down

0 comments on commit 80bd8be

Please sign in to comment.