refactor: Update to match some improvements in the Maya submitter #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epmog
approved these changes
Sep 7, 2023
* Cleanup to hatch_version_hook.py * Change the job bundle test runner to match the refactoring done in Maya, including placing the scene file in a scene subdirectory and separating the Nuke-specific parts into a set of interface functions that we can turn into a class in a follow-up refactor. * Reduce the code coverage threshold 63 -> 62. Note that we want to put the job bundle output tests in our CI/CD pipelines as the real mechanism for test coverage instead of mock-based unit tests. Signed-off-by: Mark Wiebe <markw@amazon.com>
mwiebe
force-pushed
the
markw/nuke-tweaks
branch
from
80812f8
to
17729d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
When updating the Maya submitter, I made improvements that are also useful for Nuke.
What was the solution? (How)
What is the impact of this change?
Easier time using the job bundle output tests.
How was this change tested?
Ran the job bundle tests.
Did you run the "Job Bundle Output Tests"? If not, why not? If so, paste the test results here.
I ran them before rebase, here are the outputs from that.
Was this change documented?
No
Is this a breaking change?
No