Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ability to configure timeouts in submission UI #143

Merged
merged 1 commit into from
May 24, 2024

Conversation

AWS-Samuel
Copy link
Contributor

@AWS-Samuel AWS-Samuel commented May 14, 2024

What was the problem/requirement? (What/Why)

There was no mechanism to set timeouts for session/environment actions through the submitter.

What was the solution? (How)

Add the UI. The default looks like the following:
image

  • Use Timeouts is a sticky setting
  • The values of each timeout type are a sticky setting

A warning pops up when deselecting the Use Timeouts checkbox

image

Zero-valued timeouts are not valid, and are highlighted red to help with identification

image

  • On submission the following error pops up for zero-valued timeouts
    image

The timeout fields are disabled when the Use Timeouts checkbox is not selected

image

  • Additionally, the zero-value validation is disabled when this checkbox is deselected

What is the impact of this change?

Users can set timeouts in their job and have the corresponding action timeout when the duration has elapsed.

How was this change tested?

  • UI was manually tested
  • Submitted a job using these changes and confirmed that the job timed out accordingly

Did you run the "Job Bundle Output Tests"? If not, why not? If so, paste the test results here.

Yes, I updated the job bundle output test job templates as the default value for the timeout fields has changed the expected template


Timestamp: 2024-05-14T11:54:56.189556-05:00
Running job bundle output test: C:\Users\samcan\git\deadline\deadline-cloud-for-nuke\job_bundle_output_tests\cwd-path

cwd-path
Test succeeded

Timestamp: 2024-05-14T11:54:58.856255-05:00
Running job bundle output test: C:\Users\samcan\git\deadline\deadline-cloud-for-nuke\job_bundle_output_tests\group-read

group-read
Test succeeded

Timestamp: 2024-05-14T11:54:59.780206-05:00
Running job bundle output test: C:\Users\samcan\git\deadline\deadline-cloud-for-nuke\job_bundle_output_tests\multi-load-save

multi-load-save
Test succeeded

Timestamp: 2024-05-14T11:55:01.078336-05:00
Running job bundle output test: C:\Users\samcan\git\deadline\deadline-cloud-for-nuke\job_bundle_output_tests\noise-saver

noise-saver
Test succeeded

Timestamp: 2024-05-14T11:55:02.101071-05:00
Running job bundle output test: C:\Users\samcan\git\deadline\deadline-cloud-for-nuke\job_bundle_output_tests\ocio

ocio
Test succeeded

All tests passed, ran 5 total.
Timestamp: 2024-05-14T11:55:06.716752-05:00

Was this change documented?

Yes

Is this a breaking change?

No

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@AWS-Samuel AWS-Samuel force-pushed the add-timeouts branch 3 times, most recently from 783216a to 9f3684c Compare May 15, 2024 17:18
@AWS-Samuel AWS-Samuel marked this pull request as ready for review May 16, 2024 15:04
@AWS-Samuel AWS-Samuel requested a review from a team as a code owner May 16, 2024 15:04
@AWS-Samuel AWS-Samuel force-pushed the add-timeouts branch 3 times, most recently from f14fb78 to 995c1d3 Compare May 16, 2024 18:41
epmog
epmog previously approved these changes May 17, 2024
epmog
epmog previously approved these changes May 21, 2024
Signed-off-by: Samuel Anderson <119458760+AWS-Samuel@users.noreply.github.com>
Copy link

sonarcloud bot commented May 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@AWS-Samuel AWS-Samuel merged commit 4535fa0 into aws-deadline:mainline May 24, 2024
10 checks passed
@AWS-Samuel AWS-Samuel deleted the add-timeouts branch May 24, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants