-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add OCIO configuration to Job Environments #166
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eherozhao
reviewed
Sep 17, 2024
crowecawcaw
reviewed
Sep 17, 2024
crowecawcaw
requested changes
Sep 17, 2024
crowecawcaw
previously approved these changes
Sep 18, 2024
lucaseck
reviewed
Sep 18, 2024
lucaseck
reviewed
Sep 18, 2024
lucaseck
approved these changes
Sep 18, 2024
Signed-off-by: Haejung Choi <chaejung@amazon.com>
Signed-off-by: Haejung Choi <chaejung@amazon.com>
…d job bundle output Signed-off-by: Haejung Choi <chaejung@amazon.com>
Quality Gate passedIssues Measures |
crowecawcaw
approved these changes
Sep 19, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
What was the solution? (How)
What is the impact of this change?
How was this change tested?
Did you run the "Job Bundle Output Tests"? If not, why not? If so, paste the test results here.
Was this change documented?
No
Is this a breaking change?
No - In Nuke, environment variable takes precedence over other ocio configurations. (Ex. When OCIO environment variable is set, updating custom config in UI is disabled with the message:
OCIO environment variable is set. Setting OCIO configs from within Nuke will be disabled.
)The existing user who uses custom config will continue to work.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.