Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update README.md with follow-able command #167

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

diane-hj
Copy link
Contributor

What was the problem/requirement? (What/Why)

The previous PR #152 had some comments that would help customer experience in installation

What was the solution? (How)

Address comments

What is the impact of this change?

Customers will get some ideas how/where Nuke is installed in Mac OS. Also, when installing the submitter, customers will be able to copy and paste the command.

How was this change tested?

- `hatch build`
- `pip install dist/deadline_cloud_for_nuke-0.18.4.post4+g8b8bb17-py3-none-any.whl -t ~/deadline-cloud-for-nuke` 
- `export NUKE_PATH=~/deadline-cloud-for-nuke/src/deadline/nuke_submitter`
- `./Nuke15.0 `

Verified that Nuke has Submitter option on top

Did you run the "Job Bundle Output Tests"? If not, why not? If so, paste the test results here.


Timestamp: 2024-09-17T20:30:13.673943-07:00
Running job bundle output test: /Users/chaejung/Desktop/submitter/deadline-cloud-for-nuke/job_bundle_output_tests/group-read

group-read
Test succeeded

Timestamp: 2024-09-17T20:30:14.075840-07:00
Running job bundle output test: /Users/chaejung/Desktop/submitter/deadline-cloud-for-nuke/job_bundle_output_tests/noise-saver

noise-saver
Test succeeded

Timestamp: 2024-09-17T20:30:14.479238-07:00
Running job bundle output test: /Users/chaejung/Desktop/submitter/deadline-cloud-for-nuke/job_bundle_output_tests/multi-load-save

multi-load-save
Test succeeded

Timestamp: 2024-09-17T20:30:14.858712-07:00
Running job bundle output test: /Users/chaejung/Desktop/submitter/deadline-cloud-for-nuke/job_bundle_output_tests/frame

frame
Test succeeded

Timestamp: 2024-09-17T20:30:15.255162-07:00
Running job bundle output test: /Users/chaejung/Desktop/submitter/deadline-cloud-for-nuke/job_bundle_output_tests/ocio

ocio
Test succeeded

Timestamp: 2024-09-17T20:30:15.657983-07:00
Running job bundle output test: /Users/chaejung/Desktop/submitter/deadline-cloud-for-nuke/job_bundle_output_tests/cwd-path

cwd-path
Test succeeded

All tests passed, ran 6 total.
Timestamp: 2024-09-17T20:30:23.120486-07:00

Was this change documented?

Yes

Is this a breaking change?

No


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Signed-off-by: Haejung Choi <chaejung@amazon.com>
@diane-hj diane-hj requested a review from a team as a code owner September 18, 2024 03:36
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Signed-off-by: Haejung Choi <chaejung@amazon.com>
Copy link

sonarcloud bot commented Sep 18, 2024

@diane-hj diane-hj merged commit 5eea0a8 into aws-deadline:mainline Sep 18, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants