fix: adaptor wheel error dialog and unit test coverage #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tincheng
force-pushed
the
tincheng/unit_test_coverage
branch
4 times, most recently
from
3a67d4d
to
286dc15
Compare
tincheng
force-pushed
the
tincheng/unit_test_coverage
branch
from
286dc15
to
d27dc3f
Compare
tincheng
changed the title
rmv
reviewed
Sep 13, 2023
test/deadline_adaptor_for_nuke/unit/NukeAdaptor/test_adaptor.py
Outdated
Show resolved
Hide resolved
agerveshi
approved these changes
Sep 14, 2023
test/deadline_submitter_for_nuke/unit/test_deadline_submitter_for_nuke.py
Outdated
Show resolved
Hide resolved
test/deadline_submitter_for_nuke/unit/test_template_output/expected_job_template_output.py
Outdated
Show resolved
Hide resolved
tincheng
force-pushed
the
tincheng/unit_test_coverage
branch
from
d27dc3f
to
3722365
Compare
test/deadline_submitter_for_nuke/unit/test_template_output/expected_job_template_output.py
Outdated
Show resolved
Hide resolved
amznestebanpapp
approved these changes
Sep 18, 2023
rmv
approved these changes
Sep 18, 2023
| @@ -673,3 +730,34 @@ def test_does_nothing_if_nuke_not_running( | |||
| # THEN | |||
| assert "CANCEL REQUESTED" in caplog.text | |||
| assert "Nothing to cancel because Nuke is not running" in caplog.text | |||
|
|
|||
|
|
|||
| class TestNukeAdaptor_get_major_minor_version: | |||
There was a problem hiding this comment.
Missing type hints in these methods
tincheng
force-pushed
the
tincheng/unit_test_coverage
branch
from
3722365
to
f775b71
Compare
jlangmann-aws
approved these changes
Sep 18, 2023
mwiebe
requested changes
Sep 18, 2023
test/deadline_submitter_for_nuke/unit/test_deadline_submitter_for_nuke.py
Outdated
Show resolved
Hide resolved
test/deadline_submitter_for_nuke/unit/test_deadline_submitter_for_nuke.py
Outdated
Show resolved
Hide resolved
test/deadline_submitter_for_nuke/unit/test_deadline_submitter_for_nuke.py
Outdated
Show resolved
Hide resolved
tincheng
force-pushed
the
tincheng/unit_test_coverage
branch
2 times, most recently
from
9c754ca
to
36af21e
Compare
Signed-off-by: Ting Cheng <36546476+tincheng@users.noreply.github.com>
Signed-off-by: Ting Cheng <36546476+tincheng@users.noreply.github.com>
tincheng
force-pushed
the
tincheng/unit_test_coverage
branch
from
36af21e
to
4e9116d
Compare
mwiebe
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
FileNotFoundErrorinstead of the intendedThe Developer Option 'Include Adaptor Wheels' is enabled, but the wheels directory does not existmessageWhat was the solution? (How)
is_dir()instead ofexists()What is the impact of this change?
Better test coverage and small fix for user experience
How was this change tested?
hatch run testDid you run the "Job Bundle Output Tests"? If not, why not? If so, paste the test results here.
No - I was not able to run the Job Bundle Output Tests on Mac. Got
Failed 2 tests, succeeded 0. See the file /Users/tincheng/workplace/deadline-cloud-for-nuke/job_bundle_output_tests/test-job-bundle-results.txt for a full report.and the output file was blank. Probably need more time to get the bundle tests working on Mac, but I think this PR should have low impact without this as changes are either just unit tests or had been verified within DCC.Was this change documented?
No
Is this a breaking change?
No