chore: add mac to github workflows #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jericht
force-pushed
the
jericht/macwindows_burger
branch
from
c2fcca2
to
04d8fd4
Compare
jericht
changed the title
|
Removed Windows CI because adaptor runtime is using Unix sockets which fails the tests on Windows as that's not available |
jericht
force-pushed
the
jericht/macwindows_burger
branch
from
04d8fd4
to
4e73b08
Compare
epmog
approved these changes
Sep 21, 2023
amarsjac
approved these changes
Sep 21, 2023
Signed-off-by: Jericho Tolentino <68654047+jericht@users.noreply.github.com>
jericht
force-pushed
the
jericht/macwindows_burger
branch
from
4e73b08
to
01bfe94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
We should be building & testing our code on Windows and Mac
What was the solution? (How)
Modify GitHub workflows so they are building & testing our code on Windows and Mac. Made similar changes done in aws-deadline/deadline-cloud@afef801#diff-a1a47fe3f012a1f3ed362997e7d812693102beecce28d3eebbd7f446795d84d5
What is the impact of this change?
GitHub workflows are building & testing our code on Windows and Mac
How was this change tested?
GitHub workflows are building & testing our code on Windows and Mac
Was this change documented?
No
Is this a breaking change?
No
🍎 🪟 🍔