fix: BYO Deadline now looks specifically for resource env vars. #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eric Osiowy <134728121+erico-aws@users.noreply.github.com>
moorec-aws
approved these changes
Jul 9, 2024
ttblanchard
approved these changes
Jul 10, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
The fields of DeadlineResources don't match the kwargs in it's constructor. Either, you don't provide
FARM,FLEETandQUEUEand the required field validation fails OR you do provide them and the constructor for DeadlineResources fails because it doesn't recognize a keyword namedfarm.What was the solution? (How)
We're going to leave validation of required fields to the dataclass itself. Pull the specific env vars we want out for specifying the resources.
What is the impact of this change?
Unblocks BYO Deadline testing workflows.
How was this change tested?
I have an existing Farm, Fleet and Queue. I was able to use these fixtures to run tests against them. My account is limited to on 2 Farms (which I already have) if this didn't work I would have gotten errors making a new Farm.
Was this change documented?
No.
Is this a breaking change?
No.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.