fix: resolve get_worker_id race by waiting for worker.json to get written #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWS-Samuel
previously approved these changes
Aug 2, 2024
…tten Problem: When starting a worker using PosixInstanceWorker it can sometimes be the case that we query for the Worker's id before the worker.json file has been written to disk. If this happens then the test will fail. Solution: Repeatedly query for the worker.json file in a delaying loop, up to a maximum of 10 queries after about a minute. Signed-off-by: Daniel Neilson <53624638+ddneilson@users.noreply.github.com>
ddneilson
force-pushed
the
wait_for_state_file
branch
from
e716276
to
5b71c8f
Compare
AWS-Samuel
approved these changes
Aug 2, 2024
|
epmog
approved these changes
Aug 2, 2024
ttblanchard
approved these changes
Aug 2, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
When starting a worker using PosixInstanceWorker it can sometimes be the case that we query for the Worker's id before the worker.json file has been written to disk. If this happens then the test will fail.
What was the solution? (How)
Repeatedly query for the worker.json file in a delaying loop, up to a maximum of 10 queries after about a minute. Note that this mitigation was already implemented for the Windows agent, but was missing in the Linux agent.
What is the impact of this change?
Fewer flaky tests.
How was this change tested?
I ran the deadline-cloud-worker-agent e2e tests on linux.
Was this change documented?
N/A
Is this a breaking change?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.