fix: increase number of retries for SSM send_command to 60 #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yutong Li <52769999+YutongLi291@users.noreply.github.com>
|
AlexTranAmz
approved these changes
Aug 14, 2024
leongdl
approved these changes
Aug 14, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
Windows workers boot up takes longer than Linux workers, so the current total retry time to verify that we can send an SSM command, which is 5 minutes is not sufficient, in rare cases.
What was the solution? (How)
Increase the timeout for sending an SSM command on a launched EC2 instance.
What is the impact of this change?
More slack in waiting for the windows worker to be booted, less flakiness
How was this change tested?
hatch run fmt
Pulled the worker agent package and installed this version of test-fixtures, confirmed that the timeout was increase and it successfully waited for the worker to start.
Was this change documented?
no
Is this a breaking change?
no
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.