fix: append export AWS_ENDPOINT_URL_DEADLINE at end of worker SSM commands #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mands Signed-off-by: Yutong Li <52769999+YutongLi291@users.noreply.github.com>
leongdl
approved these changes
Aug 14, 2024
|
ddneilson
approved these changes
Aug 14, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
When we spin up multiple workers, the 2nd worker and so forth always fails since in the command to install the worker agent, we
runuseras a deadline-worker user that has not been created yet, trying to export an env variable.What was the solution? (How)
Move the
runusercommand to the end of the commands, so the user is actually created during the worker agent install.What is the impact of this change?
The failing worker-agent tests that use a separate worker from the main session worker should pass again
How was this change tested?
Built into worker-agent repo, and used
hatch run cross-os-e2e-testto verify on Linux that it worksWas this change documented?
No
Is this a breaking change?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.