fix: start windows worker service depending on the worker configuration #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yutong Li <52769999+YutongLi291@users.noreply.github.com>
|
AlexTranAmz
reviewed
Aug 16, 2024
AlexTranAmz
approved these changes
Aug 16, 2024
YutongLi291
changed the title
ddneilson
approved these changes
Aug 16, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
The Posix deadline-worker service started depending on whether the worker configuration had
start_serviceset to True or False, but the WIndows service did not.What was the solution? (How)
Also make the WIndows service dependent on the worker configuration in specifying whether the service should start after the install.
What is the impact of this change?
Better and more consistent testing experience across Windows and Posix
How was this change tested?
hatch run fmt, hatch build
Was this change documented?
No
Is this a breaking change?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.