-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: provision ownership on /var/lib/deadline/credentials directory #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jusiskin
requested changes
Feb 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for helping improve this. Just one suggested change here.
jusiskin
reviewed
Feb 2, 2024
gahyusuh
force-pushed
the
gahyusuh/smf_worker_cred_dir_ownership
branch
from
February 2, 2024 19:38
8ce0b7a
to
3854b78
Compare
jusiskin
requested changes
Feb 2, 2024
Signed-off-by: Gahyun Suh <132245153+gahyusuh@users.noreply.github.com>
gahyusuh
force-pushed
the
gahyusuh/smf_worker_cred_dir_ownership
branch
from
February 2, 2024 21:42
3854b78
to
ffde35f
Compare
jusiskin
approved these changes
Feb 2, 2024
marofke
approved these changes
Feb 5, 2024
gmchale79
pushed a commit
that referenced
this pull request
Feb 12, 2024
…145) Signed-off-by: Gahyun Suh <132245153+gahyusuh@users.noreply.github.com> Signed-off-by: Graeme McHale <gmchale@amazon.com>
This was referenced Feb 22, 2024
Closed
Merged
Merged
jusiskin
pushed a commit
to jusiskin/deadline-cloud-worker-agent
that referenced
this pull request
Sep 4, 2024
Signed-off-by: client-software-ci <129794699+client-software-ci@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
The worker credentials directory
/var/lib/deadline/credentials
is world read/executable in a worker agent in a SMF. While the credentials for the worker agent are not accessible, we should make this directory inaccessible as a best practice.What was the solution? (How)
Updated the
install.sh
to pre-create the directory and set the correct ownership and permissions. This ensures that the directory is secure from the moment it's created, aligning with best practices for handling sensitive directory.What is the impact of this change?
This change proactively secures the credentials directory.
How was this change tested?
hatch run fmt && hatch run lint && hatch run test
/var/lib/deadline
: The ownerdeadline-worker-agent
has full access. The owning groupdeadline-job-users
has read and execute permissions. No permissions have been granted to other users./var/lib/deadline/credentials
: Only the ownerdeadline-worker-agent
has full access. Neither the owning group members nor any other users have been granted any permissions.Was this change documented?
No.
Is this a breaking change?
No.