fix: no longer sigterm agent when running jobs as same user #161
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
When running jobs as the same user as the agent (i.e. the Queue's jobsRunAs user is the same os user) the agent is SIGTERMing itself when there is no work left for it to work on. It shouldn't be doing that.
What was the solution? (How)
We were doing a /usr/bin/whoami to find out who the agent is running as, but that output had a trailing newline that was interfering with the check for whether the job user and agent user are the same. This fixes that.
What is the impact of this change?
The agent can no longer be convinced to take a long walk off of a short pier.
How was this change tested?
I updated the unit tests, but also:
Was this change documented?
N/A
Is this a breaking change?
No